Pine Script reviewProgramming Training

TradingView Pine Script review (not trading advice)

Delivery from 1 dayRevisions includedQuality check
Packages
Payment protectionDetails
  • Revisions within the package are free.
  • If you do not respond within 3 days of delivery, the work is accepted automatically.
Order · $35

The money is reserved when you pay and released only once you accept the work.

TradingView Pine Script review (not trading advice)

Example result

Example for the Standard package

Code review: Python order-import script for a small online shop

What the code does

  1. Reads orders.csv from the shop export.
  2. For each order line, finds the product by SKU in stock.xlsx and subtracts the quantity.
  3. Writes the updated stock back and logs totals to import_log.txt.

The structure is clear and functions are well named. Most issues are about input that does not look the way the script expects.

Bugs and weak spots

#LineSeverityIssue
148HighThe same CSV can be imported twice; there is no check for already processed order IDs. This is the most likely cause of negative stock.
272Highint(row["qty"]) crashes on empty or "2.0" values from refunded orders.
395MediumSKU lookup is case-sensitive: "gt-101" and "GT-101" are treated as different products.
4130MediumThe file is opened without encoding="utf-8", so product names with accents break on Windows.
5201LowBare except: hides real errors and makes the log useless.

Corrected fragments

Issue 1: skip orders already imported

processed = load_processed_ids("processed_orders.txt")
for row in reader:
    if row["order_id"] in processed:
        continue
    # ... existing logic ...
    processed.add(row["order_id"])
save_processed_ids("processed_orders.txt", processed)

Why: each order is applied once, even if you run the script on the same file again.

Issue 2: read quantity safely

raw = (row.get("qty") or "").strip()
try:
    qty = int(float(raw))
except ValueError:
    log.warning("Order %s: bad quantity %r, skipped", row["order_id"], raw)
    continue

Why: refunded or partial lines are skipped with a clear note instead of stopping the whole import.

Issue 3: normalise SKUs

sku = row["sku"].strip().upper()

Apply the same .strip().upper() when building the stock dictionary.

Style and readability

  • process() is 90 lines long; split it into read_orders, apply_to_stock, write_report.
  • Replace magic column numbers (row[7]) with header names.

Please test each fix on a copy of your files: we read the code but did not run it.

Client: owner of a tea shop who wrote a 310-line Python script that imports orders from a CSV export into the stock spreadsheet Problem reported: "Sometimes stock goes negative, and the script crashes on some files."

The client and all details are made up.

About this service

Pine Script indicators and strategies often look better on the chart than they behave live, because of repainting from request.security with lookahead, signals taken on bars that have not closed, or a strategy that fills orders in a way the real market would not. We read your script, explain how it calculates on each bar, and mark compile errors, repainting and logic that does not match what you meant. We review the code only and say nothing about whether the strategy will make money.

What is included

  • What you getA written review on the order page: how your script calculates bar by bar, errors and repainting risks by importance, and corrected Pine Script fragments. Premium adds notes on updating the script to the current Pine version.
  • Compile errorsExplained and fixed
  • Repainting checkrequest.security, lookahead, bar state
  • Logic vs intentDoes the code do what you meant
  • Strategy settingsOrder fills, commission, pyramiding
  • AlertsConditions that fire once per signal

How it works

  1. 1
    BriefYou paste the script and its purpose
  2. 2
    ReadingWe trace the calculation on each bar
  3. 3
    ReviewYou get errors, risks and fixed code

What we need from you

The script pasted as text, its Pine version line, whether it is an indicator or a strategy, the symbol and timeframe you use and what each signal is meant to show.

We will ask you:

  • Is it an indicator or a strategy?
  • Which Pine version is at the top of the script?
  • What should each signal or line show?
  • Do you use alerts or higher timeframe data?

Compare packages

PackagesBasicScript up to 100 lines$15StandardScript up to 400 lines$35PremiumUp to 1,000 lines with version notes$69
Deadline1 day2 days3 days
Revisions123
Lines of codeup to 100up to 400up to 1,000
Corrected fragmentsYesYesYes
Pine version upgrade notesNoNoYes
Order BasicOrder StandardOrder Premium

Payment protection

You pay when you order, but the money is released only for accepted work.

  • Fixed priceThe package price does not change after you pay.
  • The money is reservedWhen you pay, the amount is only reserved. It is released to the service once you accept the work.
  • Checked before deliveryEvery result goes through a quality check before it reaches you, and you see it on the order page before accepting it.
  • Free revisionsAsk for changes within your brief as many times as the package allows.
  • Acceptance after 3 daysIf within 3 days of delivery you neither accept the work nor ask for changes, it is accepted automatically. If you write in the order chat after delivery, the order waits; once we answer, we may start the 3 days again and will say so in the chat.
  • Redo or a full refundIf the result does not match your brief and the revisions did not fix it, or the work takes more than twice its deadline, write in the order chat: we will redo the work or refund the payment in full.
How it works →

Questions and answers

Will you tell me if my strategy is profitable?

No. This is a code review, not trading or investment advice. We check that the code does what you intend and does not repaint.

Do you run backtests?

No, we do not open TradingView for you. Run the corrected script on your chart and compare the results yourself.

Can you convert my script from version 4?

In Premium we mark what changes and give updated fragments. Check the converted script on the chart before relying on it.

Packages
Order · $35· 2 days